Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS plugin Bugfix :: Defensive checks added to prevent TaskListService crashes #17411

Merged
merged 7 commits into from
Aug 15, 2024
Merged

VS plugin Bugfix :: Defensive checks added to prevent TaskListService crashes #17411

merged 7 commits into from
Aug 15, 2024

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Jul 12, 2024

Description

We have been seeing unhandled exceptions coming from TaskListService usage in VS.
Those were coming from wrong arguments passed to IndexOf, caused by mismatches in columnar indexes.

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro
Copy link
Member Author

T-Gro commented Jul 12, 2024

/fantomas run

@T-Gro
Copy link
Member Author

T-Gro commented Jul 12, 2024

/run fantomas

@github-actions
Automated command ran: fantomas
27dbeed 
  Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Ran fantomas: https://github.com/dotnet/fsharp/actions/runs/9912563093

@T-Gro T-Gro marked this pull request as ready for review July 19, 2024 09:25
@T-Gro T-Gro requested a review from a team as a code owner July 19, 2024 09:25
@psfinaki
Copy link
Member

Any way to test this?

@T-Gro T-Gro enabled auto-merge (squash) August 15, 2024 07:50
@T-Gro T-Gro merged commit e124950 into dotnet:main Aug 15, 2024
30 checks passed
@T-Gro T-Gro deleted the fix-tasklistservice-crashes branch August 16, 2024 07:05
This was referenced Aug 20, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees

@vzarytovskii vzarytovskii

Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@T-Gro @psfinaki @abonie @vzarytovskii