Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight cleanup of dead and repeated code #17412

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Slight cleanup of dead and repeated code #17412

merged 5 commits into from
Jul 19, 2024

Conversation

KevinRansom
Copy link
Member

I've been looking around tcglobals a bit, and found some repeated and dead code.

@KevinRansom KevinRansom requested a review from a team as a code owner July 13, 2024 09:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 13, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jul 13, 2024
@KevinRansom KevinRansom merged commit 2818689 into dotnet:main Jul 19, 2024
30 checks passed
This was referenced Jul 25, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinRansom @vzarytovskii @psfinaki