-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullness - SDK prop alignment with C# - <Nullable> #17486
Conversation
✅ No release notes required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Thank you for aligning this to the existing values.
Related question - for the F# new project templates in the SDK, do you want to default |
Thanks for reminding, but I think we should wait for more stabilization + bug fixing first. @vzarytovskii : Agree? |
It's late enough in the cycle that you could definitely wait and make the change for the .NET 10 release, no worries :) |
Yep, let's not default it just yet |
This aligns the project setting needed to turn on nullability analysis and warnings.
Possible values are
<Nullable>enable,/>
and<Nullable>disable</>
.This first needs #15310 (review) to be merged in order to suceed, since that PR adds "bootstrapped Fsharp.Build" to the proto mechanism.