Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness - SDK prop alignment with C# - <Nullable> #17486

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Aug 2, 2024

This aligns the project setting needed to turn on nullability analysis and warnings.
Possible values are <Nullable>enable,/> and <Nullable>disable</>.

This first needs #15310 (review) to be merged in order to suceed, since that PR adds "bootstrapped Fsharp.Build" to the proto mechanism.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ No release notes required

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thank you for aligning this to the existing values.

@baronfel
Copy link
Member

baronfel commented Aug 2, 2024

Related question - for the F# new project templates in the SDK, do you want to default <Nullable>enable</Nullable>? If so that would need to be done ASAP.

@T-Gro
Copy link
Member Author

T-Gro commented Aug 2, 2024

Related question - for the F# new project templates in the SDK, do you want to default <Nullable>enable</Nullable>? If so that would need to be done ASAP.

Thanks for reminding, but I think we should wait for more stabilization + bug fixing first.

@vzarytovskii : Agree?

@baronfel
Copy link
Member

baronfel commented Aug 2, 2024

It's late enough in the cycle that you could definitely wait and make the change for the .NET 10 release, no worries :)

@vzarytovskii
Copy link
Member

Related question - for the F# new project templates in the SDK, do you want to default <Nullable>enable</Nullable>? If so that would need to be done ASAP.

Thanks for reminding, but I think we should wait for more stabilization + bug fixing first.

@vzarytovskii : Agree?

Yep, let's not default it just yet

@T-Gro T-Gro self-assigned this Aug 2, 2024
@T-Gro T-Gro marked this pull request as ready for review August 15, 2024 07:50
@T-Gro T-Gro requested a review from a team as a code owner August 15, 2024 07:50
@T-Gro T-Gro enabled auto-merge (squash) August 15, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Nullness issue - support direct <Nullable>enable</Nullable> flag instead of <OtherOptions>
4 participants