Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ILTypeDef custom attributes changes #17503

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Revert ILTypeDef custom attributes changes #17503

merged 5 commits into from
Aug 15, 2024

Conversation

auduchinok
Copy link
Member

The nullness PR introduced some changes that break our usages of ILTypeDef type. This PR reverts these changes.

@auduchinok auduchinok requested a review from a team as a code owner August 7, 2024 13:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@auduchinok @DedSec256
Update src/Compiler/AbstractIL/il.fs
1e2da9b 
Co-authored-by: Alex Berezhnykh <berejnih.alex2011@yandex.ru>
@vzarytovskii
Copy link
Member

Wait, does it revert changes introduced in nullness PR, or in some other PR?

@auduchinok
Copy link
Member Author

Wait, does it revert changes introduced in nullness PR, or in some other PR?

It reverts the public API changes introduced in the nullness PR. The underlying representation of ILTypeDef has not been changed there.

@vzarytovskii vzarytovskii requested a review from T-Gro August 7, 2024 15:08
@T-Gro T-Gro self-assigned this Aug 14, 2024
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 15, 2024
@T-Gro T-Gro enabled auto-merge (squash) August 15, 2024 08:26
@T-Gro
Copy link
Member

T-Gro commented Aug 15, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro merged commit c9bed79 into dotnet:main Aug 15, 2024
30 checks passed
@auduchinok auduchinok deleted the ilTypeDef-customAttrsStored branch August 15, 2024 17:04
This was referenced Aug 20, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

@DedSec256 DedSec256 DedSec256 approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees

@T-Gro T-Gro

Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@auduchinok @vzarytovskii @T-Gro @DedSec256 @edgarfgp