-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack MIBC files #17513
Pack MIBC files #17513
Conversation
✅ No release notes required |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna block it to not forget to review on Monday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to deploy all of the packages to the SDK. Size is not that big a deal.
There are issues with locking files. I suggest to copy initially to two different paths - mibc and mibc_proto or something. And apply to proto from mibc_proto, and copy to nuget from the other one. |
|
Sure let me try something. |
After restore, it seems that files are getting locked:
Maybe @baronfel and/or @rainersigwald have some advise here? |
Well, worst case scenario, we can just slap |
Putting this in You just want this once/build, right? But "in any way the build could be triggered" is why you're putting it in D.b.targets? |
That's a good point, I haven't thought about it 🤦
Yep, pretty much, we want it to happen once, no matter what we're building. |
In that case what I'd do is this:
Then the MSBuild engine will deduplicate the request and do the copy operation only once. |
Ooh, nice, thanks a tonne, Rainer, will try it out tomorrow! |
@KevinRansom @vzarytovskii this is finally green! 🍾 |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
🍾 🍾 🍾 |
Fixes: #12636
Fixes: #13328
Part one of implementing PGO in F# - this copying the restores MIBC files to the resulting NuGet packages.
The result looks like this: