VS: fix unwanted navigation on hover

[majocha]

Don't show the window, return a nav item instead.

Fixes #17230.

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
vsintegration/src	docs/release-notes/.VisualStudio/17.12.md

[majocha]

@vzarytovskii I don't have much time to test it at the moment, but that's what I'd try.

[vzarytovskii]

I am on leave now and can't test it, but unsure if we return the nav item without showing it, Roslyn will understand it and will switch focus, if it's not a part of its original workspace. And we can't add it to current workspace, since it might break checking. Maybe we can try adding it to miscellaneous files namespace, but then highlighting might break.

[majocha]

No worries :) I just tested it. Looks like with this change navigation to metadata still works. I can F12 or ctrl+click and I get metadata source with typecheck and semantic colors.

I think we don't need to use current workspace. Roslyn creates and uses a separate workspace for metadata as source in their own implementation:

https://sourceroslyn.io/#Microsoft.CodeAnalysis.Features/MetadataAsSource/MetadataAsSourceFileService.cs,96

[T-Gro]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[T-Gro]

Tested locally.

Desired navigation to external metadata still works.
Undesired navigation no longer happens to me.

Thinking about it, I was getting it during the summer as well, but was contributing it to my fat fingers.
The typical use case happening to me was when selecting a longIdent with mouse, CTRL+C for copying, which sometimes jumped me to decompiled source.

(now I know that it only happened when I was copypasting external symbols, and my mouse pointer was above the text).

[vzarytovskii]

Tested locally.

Desired navigation to external metadata still works.

Undesired navigation no longer happens to me.

Thinking about it, I was getting it during the summer as well, but was contributing it to my fat fingers.

The typical use case happening to me was when selecting a longIdent with mouse, CTRL+C for copying, which sometimes jumped me to decompiled source.

(now I know that it only happened when I was copypasting external symbols, and my mouse pointer was above the text).

Yeah, sorry, it was my hotfix, haven't crossed my mind that hovering can lead to calling definitions API

[Thorium]

Still happens to me in VS2022 17.12 Beta...

[vzarytovskii]

Inserted month ago probably means it's in p3 or release