Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test delaying startup code to the test it belongs to #17612

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Martin521
Copy link
Contributor

@Martin521 Martin521 commented Aug 26, 2024

Description

In FSharp.Compiler.ComponentTests, a certain test module executes a lot of parsing steps in static startup code.
This not only leads to a substantial delay in test startup when executing any other single test, but also considerably impedes debugging.

This PR moves the parsing steps to the (single) test that needs them.

Notes for reviewers:
Looking at the main branch version, you see that codebases is initialized during startup. This includes running parseSourceCode 84 times and storing the resulting ASTs. The core of this PR is the removal of parseSourceCode from startup code to this place in the only test that uses the ASTs. On the way, I also removed the duplicated nested data in FileInScenario, renamed codebases to scenarios, and adapted the other tests accordingly.

@Martin521 Martin521 requested a review from a team as a code owner August 26, 2024 19:43
Copy link
Contributor

✅ No release notes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants