Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format + fix for --richerrors #17614

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

vzarytovskii
Copy link
Member

For some reason, I didn't include the --richerrors flag when committing yesterday.

Also, changed format to use ASCII characters + look a bit more different, in the format:

error FSXXXX: <Error message>
  --> /path/to/file.fsx
  1 | let context = error
					^^^^^
image

@vzarytovskii vzarytovskii requested a review from a team as a code owner August 27, 2024 12:04
Copy link
Contributor

❗ Release notes required

@vzarytovskii,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md No release notes found or release notes format is not correct

@vzarytovskii
Copy link
Member Author

/run fantomas

  Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
Copy link
Contributor

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bubbles are gone, I'm happy

@edgarfgp
Copy link
Contributor

edgarfgp commented Aug 27, 2024

What are your thoughts on having something similar to Gleam compiler errors. ?

Screenshot 2024-08-27 at 14 39 55

Source: https://gleam.run/news/fault-tolerant-gleam/

@vzarytovskii
Copy link
Member Author

vzarytovskii commented Aug 28, 2024

What are your thoughts on having something similar to Gleam compiler errors. ?

Screenshot 2024-08-27 at 14 39 55

Source: https://gleam.run/news/fault-tolerant-gleam/

This is what we having pretty much, except simpler presentation. Can change it in further PRs. And as for messaging - we don't have that information at this point. We currently only have number, message and context.

@vzarytovskii vzarytovskii merged commit c8f22cd into dotnet:main Aug 28, 2024
28 checks passed
@edgarfgp
Copy link
Contributor

edgarfgp commented Aug 28, 2024

What are your thoughts on having something similar to Gleam compiler errors. ?
Screenshot 2024-08-27 at 14 39 55
Source: https://gleam.run/news/fault-tolerant-gleam/

This is what we having pretty much, except simpler presentation. Can change it in further PRs. And as for messaging - we don't have that information at this point. We currently only have number, message and context.

@vzarytovskii
I guess we could

  • Replace the absolute path with a relative path
  • Replace -> | with to simply this.

Regarding we don't have that information at this point

@vzarytovskii
Copy link
Member Author

What are your thoughts on having something similar to Gleam compiler errors. ?

Screenshot 2024-08-27 at 14 39 55

Source: https://gleam.run/news/fault-tolerant-gleam/

This is what we having pretty much, except simpler presentation. Can change it in further PRs. And as for messaging - we don't have that information at this point. We currently only have number, message and context.

@vzarytovskii

I guess we could

  • Replace the absolute path with a relative path

I can do that where possible.

  • Replace -> | with to simply this.

I personally think that standard easily typeable symbols read better, but we can try and see how it looks.

Regarding we don't have that information at this point

I will and it won't at the same time, info from it can be used, but it needs to be plumbed there, and it'll either need to be processed case by case where to put it or provide pairs of range-message to automatically print. In other words there needs to be a new mechanism introduced which will be responsible for providing additional contextual info, which can be printed without the need to know how it's structured.

@edgarfgp
Copy link
Contributor

What are your thoughts on having something similar to Gleam compiler errors. ?
Screenshot 2024-08-27 at 14 39 55
Source: https://gleam.run/news/fault-tolerant-gleam/

This is what we having pretty much, except simpler presentation. Can change it in further PRs. And as for messaging - we don't have that information at this point. We currently only have number, message and context.

@vzarytovskii I guess we could

  • Replace the absolute path with a relative path
  • Replace -> | with to simply this.

Regarding we don't have that information at this point

Sounds like we will need a plan/document to formalise this new approach, So we can incrementally improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants