-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change format + fix for --richerrors
#17614
Conversation
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
/run fantomas |
Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bubbles are gone, I'm happy
What are your thoughts on having something similar to |
This is what we having pretty much, except simpler presentation. Can change it in further PRs. And as for messaging - we don't have that information at this point. We currently only have number, message and context. |
@vzarytovskii
Regarding
|
I can do that where possible.
I personally think that standard easily typeable symbols read better, but we can try and see how it looks.
I will and it won't at the same time, info from it can be used, but it needs to be plumbed there, and it'll either need to be processed case by case where to put it or provide pairs of range-message to automatically print. In other words there needs to be a new mechanism introduced which will be responsible for providing additional contextual info, which can be printed without the need to know how it's structured. |
Sounds like we will need a plan/document to formalise this new approach, So we can incrementally improve this. |
For some reason, I didn't include the
--richerrors
flag when committing yesterday.Also, changed format to use ASCII characters + look a bit more different, in the format: