Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw from IsUnionCaseTester and handle a case where symbol is not considered a method/property #17634

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Do not throw from IsUnionCaseTester and handle a case where symbol is not considered a method/property #17634

merged 7 commits into from
Aug 30, 2024

Conversation

abonie
Copy link
Member

@abonie abonie commented Aug 29, 2024 •
edited
Loading

Description

Fixes #17301

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@abonie abonie changed the title [WIP] Isunioncasetester throws [WIP] Do not throw from IsUnionCaseTester and handle a case where symbol is not considered a method/property Aug 29, 2024
abonie added 2 commits August 29, 2024 18:49
@abonie
Fix IsUnionCaseTester for generated code
687df7c 
Seems like methods/properties that are generated in IL, like `get_Is*`
in this case, have `IsMethod` (or `IsProperty`) false for some reason,
even when `IsPropertyGetterMethod` is true. This would result in
`IsUnionCaseTester` giving incorrect answers. This fixes that at
`IsUnionCaseTester`, though it might be worth it to see if it can be
fixed at the root of the issue
@abonie
Add a release note
06a62df
@abonie abonie force-pushed the isunioncasetester_throws branch from 47ed0e3 to 06a62df Compare August 29, 2024 16:49
@abonie abonie changed the title [WIP] Do not throw from IsUnionCaseTester and handle a case where symbol is not considered a method/property Do not throw from IsUnionCaseTester and handle a case where symbol is not considered a method/property Aug 30, 2024
@abonie abonie marked this pull request as ready for review August 30, 2024 11:27
@abonie abonie requested a review from a team as a code owner August 30, 2024 11:27
@KevinRansom KevinRansom merged commit 99bd001 into dotnet:main Aug 30, 2024
30 checks passed
This was referenced Sep 11, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsUnionCaseTester throwing an error
4 participants
@abonie @KevinRansom @T-Gro @vzarytovskii