-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve StartWithContinuations test in AsyncType tests #17767
Merged
Merged
+27
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majocha
force-pushed
the
asynctype-1
branch
from
September 20, 2024 06:59
3d84c19
to
c0ce09c
Compare
✅ No release notes required |
New version goes like this: module AsyncType =
type ExpectedContinuation = Success | Exception | Cancellation
[<Fact>]
let startWithContinuations() =
let cont actual expected _ =
if expected <> actual then
failwith $"expected {expected} continuation, but ran {actual}"
let onSuccess = cont Success
let onExeption = cont Exception
let onCancellation = cont Cancellation
let expect expected computation =
Async.StartWithContinuations(computation, onSuccess expected, onExeption expected, onCancellation expected)
async {
Async.CancelDefaultToken()
return ()
} |> expect Cancellation
async { failwith "computation failed" } |> expect Exception
async { return () } |> expect Success |
psfinaki
reviewed
Sep 23, 2024
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs
Outdated
Show resolved
Hide resolved
psfinaki
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I think I've verified the equivalence, thanks for the refactoring, it definitely looks clearer now.
…ol/AsyncType.fs Co-authored-by: Petr <psfinaki@users.noreply.github.com>
T-Gro
approved these changes
Sep 30, 2024
esbenbjerre
pushed a commit
to esbenbjerre/fsharp
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a local cancellation token instead ofAsync.CancelDefaultToken()
to cancel just one computation.When running tests in parallel I've seen
OperationCancelledException
raised in unrelated tests of the same assembly.It seems despite the fact this test collection has
DisableParallelization = true
,xUnit sometimes can't perfectly isolate the test cases.ETA: It was me misconfiguring xUnit exclusions.
Still, I think this looks a bit cleaner.