Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused useSyntaxTreeCache option #17768

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Remove unused useSyntaxTreeCache option #17768

merged 8 commits into from
Sep 30, 2024

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Sep 20, 2024

Clean up.
This functionality is no longer configurable, and that cache no longer exists as a separate value in the builder.
Instead SyntaxTree caching occurs naturally by preserving GraphNode computed values, IIRC.

@majocha majocha requested a review from a team as a code owner September 20, 2024 07:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md
vsintegration/src docs/release-notes/.VisualStudio/17.12.md

@psfinaki
Copy link
Member

I think surface area will need an update as well.

@majocha
Copy link
Contributor Author

majocha commented Sep 26, 2024

The consensus is to remove it. It was also still marked experimental.

@psfinaki
Copy link
Member

I just noticed it's also present in VS settings. I think we should remove it there as well then :)

@psfinaki
Copy link
Member

(use_syntax_tree_cache)

@majocha
Copy link
Contributor Author

majocha commented Sep 26, 2024

I think this is already done in this PR.

@psfinaki
Copy link
Member

Right, sorry, I somehow mis-scrolled it 🤦 Thanks!

psfinaki
psfinaki approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this PR can serve as a good manual on how to add / remove an option to the compiler and propagate / unpropagate it everywhere :)

@psfinaki
Copy link
Member

Oh I know what I meant. This is still left in the resources via keywords, here. So can be removed there as well.

@majocha
Copy link
Contributor Author

majocha commented Sep 27, 2024

Right, couldn't find anything with search in files, makes sense now :)

@T-Gro T-Gro merged commit d0d4c0f into dotnet:main Sep 30, 2024
32 checks passed
esbenbjerre pushed a commit to esbenbjerre/fsharp that referenced this pull request Sep 30, 2024
@majocha @esbenbjerre
Remove unused useSyntaxTreeCache option (dotnet#17768)
57086e1
@majocha majocha deleted the remove-option branch October 1, 2024 05:46
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok left review comments

@vzarytovskii vzarytovskii vzarytovskii left review comments

@baronfel baronfel baronfel left review comments

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@majocha @psfinaki @baronfel @vzarytovskii @auduchinok @T-Gro