-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error reporting for return, yield, return! and yield!
#17792
Better error reporting for return, yield, return! and yield!
#17792
Conversation
❗ Release notes required
|
yield
and yield!
return, yield, return! and yield!
baf77ef
to
33bcbe3
Compare
…harp into better-error-reporting-yield
The failing tests in this PR are the |
Hmm looking at the tests, this change indeed breaks the code fix. Although the code fix itself is quite simple, shouldn't be a big deal, hope I'll get to it later today. |
There you go, there is some change in range/span arithmetic there, added a few extra tests just to be sure :) |
Thank you Sir. Enjoy the holidays :) |
…harp into better-error-reporting-yield
9bbb7d6
to
49da131
Compare
49da131
to
f98e2dd
Compare
…harp into better-error-reporting-yield
c7b3589
to
40a94ad
Compare
…harp into better-error-reporting-yield
2ca244d
to
5d3572e
Compare
This is ready |
Description
Better error reporting for
return, yield, return! and yield!
Continuation of #17779
Before
After
Before
After
Before
After
Before
After
Checklist