Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure frameworkTcImportsCache mutations are threadsafe #17795

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Ensure frameworkTcImportsCache mutations are threadsafe #17795

merged 5 commits into from
Sep 26, 2024

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Sep 26, 2024

When running tests in parallel there happened some intermittent internal errors, all of them variations of NRE.
I tracked it down to data corruption because of concurrent mutation of frameworkTcImportsCache.

@majocha majocha requested a review from a team as a code owner September 26, 2024 10:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@majocha majocha closed this Sep 26, 2024
@majocha majocha reopened this Sep 26, 2024
@majocha majocha marked this pull request as draft September 26, 2024 15:12
@majocha majocha marked this pull request as ready for review September 26, 2024 16:50
@majocha majocha mentioned this pull request Sep 26, 2024
Closed
8 tasks
psfinaki
psfinaki approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's definitely for good.

@psfinaki psfinaki enabled auto-merge (squash) September 26, 2024 18:42
@psfinaki psfinaki merged commit 340e41e into dotnet:main Sep 26, 2024
32 checks passed
esbenbjerre pushed a commit to esbenbjerre/fsharp that referenced this pull request Sep 30, 2024
@majocha @esbenbjerre
Ensure frameworkTcImportsCache mutations are threadsafe (dotnet#17795)
9696ae6 
* ensure all frameworkTcImportsCache mutations are threadsafe

* rn

* not needed
@majocha majocha deleted the frameworkTcImportsCache-concurrency branch October 1, 2024 05:48
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majocha @psfinaki @T-Gro