-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow abstract member with access modifiers in sig file #17802
Conversation
❗ Release notes required
|
@Tangent-90 - |
Hmm... I just simply find out that |
error when running
|
Seen this in the past. Had to close and reopen my PR multiple times until the CI is green. |
...mance/BasicGrammarElements/AccessibilityAnnotations/PermittedLocations/PermittedLocations.fs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. It improves by a mile the access modifiers error reporting in sig file.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
...mance/BasicGrammarElements/AccessibilityAnnotations/PermittedLocations/PermittedLocations.fs
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright then, let's get this in - thanks!
Description
Disallow abstract member with access modifiers in signature files.
Before: All these will build successfully
After: Error FS0561: Accessibility modifiers are not allowed on this member. Abstract slots always have the same visibility as the enclosing type.
Checklist