Respect generic arity in method uniqueness #17804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
…-with-identical-argument-types
|
/backport to release/dev17.12 |
|
Started backporting to release/dev17.12: https://github.com/dotnet/fsharp/actions/runs/11066471151 |
auduchinok
approved these changes
Sep 27, 2024
…ical-argument-types' of https://github.com/dotnet/fsharp into 17796-internal-error-multiple-methods-appear-with-identical-argument-types
0101
approved these changes
Sep 27, 2024
psfinaki
approved these changes
Sep 27, 2024
T-Gro
deleted the
17796-internal-error-multiple-methods-appear-with-identical-argument-types
branch
esbenbjerre
pushed a commit
to esbenbjerre/fsharp
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17796 .
An internal function for finding method definition based on a method reference existed for a long time, used on multiple places (events, base type calls,..).
It checked for equal name, return type, argument number and argument types.
However, there are APIs which are equal in all of that, and only differ in their generic arity = the number of generic arguments.
The very common
AddSingleton<> vs AddSingleton<,>is one of them.