Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrency issue in ILPreTypeDefImpl #17812

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Fix concurrency issue in ILPreTypeDefImpl #17812

merged 4 commits into from
Sep 30, 2024

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Sep 27, 2024

Custom lazy implementation does not seem to be needed in this particular case.
Fixes #17803

@majocha majocha requested a review from a team as a code owner September 27, 2024 13:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@T-Gro T-Gro enabled auto-merge (squash) September 30, 2024 11:54
@vzarytovskii vzarytovskii enabled auto-merge (squash) September 30, 2024 16:26
@vzarytovskii vzarytovskii merged commit e754739 into dotnet:main Sep 30, 2024
32 checks passed
@majocha majocha deleted the fix-il-concurrency branch October 1, 2024 05:45
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronization bug in ILPreTypeDefImpl
3 participants
@majocha @vzarytovskii @T-Gro