fix parsing table cache bug #17816
Merged
fix parsing table cache bug #17816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
T-Gro
approved these changes
Sep 30, 2024
|
The contents of the cache are semantically just pairs of numbers, right? ? |
Yes |
|
Can you add the "no release notes required" label? |
edgarfgp
added
the
NO_RELEASE_NOTES
edgarfgp
approved these changes
Sep 30, 2024
vzarytovskii
approved these changes
Oct 8, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for a bug in
Internal.Utilities.Text.Parsing.Implementation.AssocTable.The cache algorithm in
AssocTable.Readrelies on unused cache locations being marked.In the implementation of the algorithm in AssocTable,
0was used as marker.However,
0is also a valid key. This fix changes the marker to-1.(In the context of my "scoped nowarn" work, a new token type that I added was not parsed correctly. It took me some time to find the reason.)