make Assertions.withExitCode work #17830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
FSharp.Compiler.Test.Compiler.Assertions.withExitCode
work as expected.withExitCode
now asserts that the test object returns the expected integer exit code.This can be quite conveniant like in the added test (which is taken from another PR where I came upon this need).
The changes that were required down the call chain should now consistently deliver from the test object
When the above is incorperated into a
CompilationResult
, the appropriateSuccess
orFailure
case is chosen, based on the same criteria as before (presence of errors, or of an exception, or something else, depending on the context).If the test object does not return an
int
exit code, or if there is no reliable exit code (like inexecuteBuiltAppNewProcessAndReturnResult
),ExitCode=None
is returned in theCompilationResult
.Checklist