Revert PR - Make the interaction between #line and #nowarn directives consistent #17859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directives consistent
|
KevinRansom
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Oct 9, 2024
|
I'm validating this for source-build. Please wait on merging this until I finish validation (~2 hours) So far - stage 1 build looks good. Waiting on stage 2 build. [Test run](https://dev.azure.com/dnceng/internal/_build/results?buildId=2556650&view=results (internal Microsoft link) |
ellahathaway
added a commit
to dotnet/sdk
that referenced
this pull request
Oct 9, 2024
psfinaki
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Revert PR - Make the interaction between #line and #nowarn directives consistent (#17859) * merge * revert Reverting PR - Make the interaction between #line and #nowarn directives consistent * Update LanguageFeatures.fs --------- Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the PR: Make the interaction between #line and #nowarn directives consistent made it's way into the release\dev17.12 branch and the revert of it didn't.
This PR corrects that, by reverting the PR. Unfortunately the rc2 SDK shipped with the bug, in order to ensure that sourcebuild continues to build this PR contains some proj file amendments to ensure successful sourcebuild compilation of rtm with the rc2 SDK.
@vlad, since we have not rtm'd yet version number changes are not required.