Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 9rc2 #17860

Merged
merged 7 commits into from
Oct 10, 2024
Merged

.NET 9rc2 #17860

merged 7 commits into from
Oct 10, 2024

Conversation

vzarytovskii
Copy link
Member

Updates to rc2, updates FSharp.Core to latest (it will be the same which goes to release, despite it says "beta"), removes using fsharp.core project.

@vzarytovskii vzarytovskii requested a review from a team as a code owner October 9, 2024 11:52
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❗ Release notes required

@vzarytovskii,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

@vzarytovskii
Copy link
Member Author

vzarytovskii commented Oct 9, 2024

Well, it's not building due to nowarn changes which made it to rc2.

D:\a\_work\1\s\src\Compiler\pppars.fsy(38,36): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_Full has been constrained to be type 'LexerIfdefExpression'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pppars.fsy(41,73): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_Recover has been constrained to be type 'unit'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pppars.fsy(44,52): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_Expr has been constrained to be type 'LexerIfdefExpression'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(394,65): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_interactiveItemsTerminator has been constrained to be type 'SynModuleDecl list'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(423,29): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_interactiveDefns has been constrained to be type 'SynModuleDecl list'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(426,29): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_interactiveExpr has been constrained to be type 'SynModuleDecl list'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(429,29): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_interactiveHash has been constrained to be type 'SynModuleDecl list'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(444,30): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_moduleDefn has been constrained to be type 'SynModuleDecl list'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(454,32): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_opt_access has been constrained to be type ''a option'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(456,60): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_opt_attributes has been constrained to be type ''a list'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(462,59): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_hashDirective has been constrained to be type 'ParsedHashDirective'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(482,51): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_hashDirectiveArgs has been constrained to be type ''a list'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]
D:\a\_work\1\s\src\Compiler\pars.fsy(492,35): warning FS0064: This construct causes code to be less generic than indicated by the type annotations. The type variable 'gentype_hashDirectiveArg has been constrained to be type 'ParsedHashDirectiveArgument'. [D:\a\_work\1\s\src\Compiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]

I have added a nowarn, which will need to be removed once fix is in SDK

@vzarytovskii vzarytovskii merged commit 7bfc92f into dotnet:main Oct 10, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants