Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings for invalid #nowarn arguments #17871

Merged
merged 36 commits into from
Nov 5, 2024
Merged

Warnings for invalid #nowarn arguments #17871

merged 36 commits into from
Nov 5, 2024

Conversation

Martin521
Copy link
Contributor

@Martin521 Martin521 commented Oct 11, 2024 •
edited
Loading

Description

Fixes #17870
Also centralizes the distributed logic for processing #nowarn arguments, for better maintainability.

Checklist

  • Test cases added
  • Release notes entry updated

@Martin521 Martin521 mentioned this pull request Oct 11, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@Martin521 Martin521 marked this pull request as ready for review October 13, 2024 13:18
@Martin521 Martin521 requested a review from a team as a code owner October 13, 2024 13:18
KevinRansom
KevinRansom previously requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments inline

src/Compiler/Driver/CompilerConfig.fs Outdated Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/CompilerDirectives/NonStringArgs.fs Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/CompilerDirectives/NonStringArgs.fs Outdated Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/CompilerDirectives/NonStringArgs.fs Outdated Show resolved Hide resolved
src/Compiler/SyntaxTree/SyntaxTreeOps.fs Outdated Show resolved Hide resolved
@Martin521 Martin521 marked this pull request as draft October 18, 2024 08:39
T-Gro
T-Gro approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thank you for your patience with this PR!

@T-Gro T-Gro enabled auto-merge (squash) November 4, 2024 08:05
0101
0101 approved these changes Nov 4, 2024
View reviewed changes
src/Compiler/Driver/ParseAndCheckInputs.fs Outdated Show resolved Hide resolved
@Martin521 @0101
More descriptive variable names
52c3bc8 
Co-authored-by: Petr Pokorny <petr@innit.cz>
auto-merge was automatically disabled November 4, 2024 14:05

Head branch was pushed to by a user without write access

@psfinaki
Copy link
Member

psfinaki commented Nov 4, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Martin521
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 17871 in repo dotnet/fsharp

@Martin521
Copy link
Contributor Author

This is ready

@psfinaki psfinaki merged commit 72cf286 into dotnet:main Nov 5, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

@0101 0101 0101 approved these changes

@KevinRansom KevinRansom KevinRansom left review comments

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warnings for invalid #nowarn arguments
6 participants
@Martin521 @psfinaki @0101 @KevinRansom @edgarfgp @T-Gro