Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error range for struct and restricted super types inherit #17886

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Better error range for struct and restricted super types inherit #17886

merged 7 commits into from
Oct 16, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Oct 15, 2024 •
edited
Loading

Description

Better error range for struct and restricted super types inherit.

Before

Screenshot 2024-10-15 at 22 47 19

After

type C1 = class inherit System.ValueType override x.ToString() = ""  end
                        ^^^^^^^^^^^^^^^^

type TK_I_005 =
  abstract M  : unit -> unit

[<Struct>]
type TK_I_006b = 
   inherit TK_I_005
           ^^^^^^^^

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp edgarfgp changed the title Better error range for struct inherit Better error range for struct and restricted super types inherit Oct 15, 2024
@edgarfgp edgarfgp marked this pull request as ready for review October 15, 2024 21:19
@edgarfgp edgarfgp requested a review from a team as a code owner October 15, 2024 21:19
@edgarfgp edgarfgp force-pushed the better-error-range-for-inherit branch from f6965ae to 1533a83 Compare October 16, 2024 10:48
@psfinaki psfinaki merged commit 346a59f into dotnet:main Oct 16, 2024
32 checks passed
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgarfgp @vzarytovskii @T-Gro @psfinaki