simplify the code for diagnostics severity adjustment #17896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Author
|
Can somebody add the "no release notes" label? |
psfinaki
added
the
NO_RELEASE_NOTES
Contributor
|
There you go, Martin :) Thanks for splitting the refactoring into a separate PR, that's always helpful. |
KevinRansom
reviewed
Oct 18, 2024
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Thank you, nice bit of cleanup.
A couple of nits, but other than that this is ready to go.
vzarytovskii
approved these changes
Oct 20, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the code for adjusting diagnostics severity, without change to the functionality.
It will be needed for "scoped nowarn", where the adjustment logic becomes even more complex, but makes sense also in itself.