Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the code for diagnostics severity adjustment #17896

Merged
merged 14 commits into from
Oct 31, 2024
Merged

simplify the code for diagnostics severity adjustment #17896

merged 14 commits into from
Oct 31, 2024

Conversation

Martin521
Copy link
Contributor

Description

This PR simplifies the code for adjusting diagnostics severity, without change to the functionality.
It will be needed for "scoped nowarn", where the adjustment logic becomes even more complex, but makes sense also in itself.

@Martin521 Martin521 requested a review from a team as a code owner October 17, 2024 14:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@Martin521
Copy link
Contributor Author

Can somebody add the "no release notes" label?
Thanks

@psfinaki psfinaki added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Oct 17, 2024
@psfinaki
Copy link
Member

There you go, Martin :) Thanks for splitting the refactoring into a separate PR, that's always helpful.

KevinRansom
KevinRansom reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nice bit of cleanup.
A couple of nits, but other than that this is ready to go.

src/Compiler/Symbols/FSharpDiagnostic.fs Outdated Show resolved Hide resolved
src/Compiler/Driver/CompilerDiagnostics.fs Outdated Show resolved Hide resolved
@Martin521 Martin521 requested a review from KevinRansom October 23, 2024 19:56
edgarfgp
edgarfgp approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@edgarfgp edgarfgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin 👍🏻

@vzarytovskii vzarytovskii merged commit 658b245 into dotnet:main Oct 31, 2024
6 of 31 checks passed
@dotnet-bot dotnet-bot mentioned this pull request Nov 30, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarfgp edgarfgp edgarfgp approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@KevinRansom KevinRansom Awaiting requested review from KevinRansom

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Martin521 @psfinaki @vzarytovskii @KevinRansom @edgarfgp