Convert OCE to empty value on certain VS operations #17906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
T-Gro
reviewed
Oct 22, 2024
0101
added
the
NO_RELEASE_NOTES
vzarytovskii
approved these changes
Oct 22, 2024
T-Gro
approved these changes
Oct 23, 2024
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are
OperationCancelledExceptions in telemetry originating fromFSharp project options not found.inAddSemanticClassificationsAsyncandGetBlockStructureAsyncoperations.There's not much we can do without options but maybe we can just return empty results instead of propagating OCE further up.
One reason we don't have options is that when project is loading and an F# file is already open VS asks as for semantic classification, block structure (and some other things) using a
MiscellaneousFilesworkspace. There could potentially be other cases.This proposed change converts all OCEs in those operations to empty results, unless cancellation has been requested by the caller through the CT they passed us.