Fix Post on disposed mailbox (#17849) #17922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17849
pulse
disposal is undersyncRoot
lock now. Nullifying it ensures there is no attempt to set the disposed wait handle.The overall result is that
Post
on disposed mailbox does not throw unless the mailbox was created withisThrowExceptionAfterDisposed = true
. (See #13036)The issue has minimal impact as certain rare conditions must be fulfilled to trigger the bug (#17849 (comment)).
This fix does not change the general behavior which is that a disposed mailbox should stop processing messages and (I presume) should not throw unless
isThrowExceptionAfterDisposed
is set.