Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing TailCall warning in Sequential in use scope, #17897 #17927

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fix missing TailCall warning in Sequential in use scope, #17897 #17927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e06a8a3
add unit test for issue #17897
dawedawe Oct 25, 2024
62d7a6e
add missing case for Sequential to fix 17897
dawedawe Oct 25, 2024
0595384
add release notes entry
dawedawe Oct 25, 2024
4bc5e00
Merge branch 'main' into fix_17897
T-Gro Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.FSharp.Compiler.Service/9.0.200.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
### Fixed

* Fix missing TailCall warning in Sequential in use scope ([PR #17927](https://github.com/dotnet/fsharp/pull/17927))
* Fix false negatives for passing null to "obj" arguments. Only "obj | null" can now subsume any type ([PR #17757](https://github.com/dotnet/fsharp/pull/17757))
* Fix internal error when calling 'AddSingleton' and other overloads only differing in generic arity ([PR #17804](https://github.com/dotnet/fsharp/pull/17804))
* Fix extension methods support for non-reference system assemblies ([PR #17799](https://github.com/dotnet/fsharp/pull/17799))
Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Checking/TailCallChecks.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,7 @@ let CheckModuleBinding cenv (isRec: bool) (TBind _ as bind) =
// warn for recursive calls in TryWith/TryFinally operations
exprs |> Seq.iter (checkTailCall true)
| Expr.Op(args = exprs) -> exprs |> Seq.iter (checkTailCall insideSubBindingOrTry)
| Expr.Sequential(expr2 = expr2) -> checkTailCall insideSubBindingOrTry expr2
| _ -> ()

checkTailCall false bodyExpr
Expand Down
28 changes: 28 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/ErrorMessages/TailCallAttribute.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,34 @@ namespace N
"The member or function 'f' has the 'TailCallAttribute' attribute, but is not being used in a tail recursive way." }
]

[<FSharp.Test.FactForNETCOREAPP>]
let ``Warn for rec call in Sequential in use scope`` () =
"""
namespace N

module M =

[<TailCall>]
let rec f () =
let path = System.IO.Path.GetTempFileName()
use file = System.IO.File.Open(path, System.IO.FileMode.Open)
printfn "Hi!"
f ()
"""
|> FSharp
|> withLangVersion80
|> compile
|> shouldFail
|> withResults [
{ Error = Warning 3569
Range = { StartLine = 11
StartColumn = 13
EndLine = 11
EndColumn = 14 }
Message =
"The member or function 'f' has the 'TailCallAttribute' attribute, but is not being used in a tail recursive way." }
]

[<FSharp.Test.FactForNETCOREAPP>]
let ``Warn for invalid tailcalls in async expression`` () =
"""
Expand Down
Loading