Fix #17903 #18025
Merged
Fix #17903 #18025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
|
/run fantomas |
Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
Co-authored-by: Petr Pokorny <petr@innit.cz>
vzarytovskii
force-pushed
the
fix-17903
branch
from
f3548b8 to
e7ac187
Compare
|
It's hitting some awkward ILVerify error, which I don't yet understand. Gonna dig more into it. There might be a flaw in the "can I realloc it" logic, which I introduced. |
|
Alright, so the failing baseline was due to the offset of the instruction (by 2 bytes), which can be a signal of the local realloc. I would like to run it here a bunch of times to see if it's some kind of "parallel ilxgen" issue with realloc caches. Update I hope it was just a local mistake of me not properly rebuilding FCS/fslib before checking baselines. |
0101
approved these changes
Nov 29, 2024
T-Gro
approved these changes
Nov 29, 2024
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17903. Test is missing, checking the waters.
The idea of the fix is pretty dumb. The
copyOfStructaddress is leaking outside the scope which trips the locals reuse algorithm. After looking more into it, and chatting with Don, I decided to markcopyOfStructas no-reuse, but keeping it in cgbuf cache.