-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FSharpWorkspace
to FCS
#18032
Merged
Merged
Add FSharpWorkspace
to FCS
#18032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0101
added
the
NO_RELEASE_NOTES
Label for pull requests which signals, that user opted-out of providing release notes
label
Nov 19, 2024
|
vzarytovskii
approved these changes
Nov 25, 2024
Thank you for this 👍🏻 |
edgarfgp
approved these changes
Nov 26, 2024
psfinaki
approved these changes
Dec 2, 2024
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Thanks @0101 and team! |
@nojaf don't get too excited, this is a pretty early version and didn't go through much testing yet 😅 But do try it out and let us know what needs to be fixed and added! |
Well, true, but at least it is out there. |
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
NO_RELEASE_NOTES
Label for pull requests which signals, that user opted-out of providing release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
FSharpWorkspace
experimental API.Also some updates on
FSharpProjectSnapshot
to reflect that we need to be able to efficiently swap referenced projects and files when they change.Checklist
[<Experimental>]
attributes or is the top level one enough? Should be enough.[ ] Performance benchmarks added in case of performance changes[ ] Release notes entry updated