Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FSharpWorkspace to FCS #18032

Merged
merged 20 commits into from
Dec 3, 2024
Merged

Add FSharpWorkspace to FCS #18032

merged 20 commits into from
Dec 3, 2024

Conversation

0101
Copy link
Contributor

@0101 0101 commented Nov 19, 2024

Description

Adding FSharpWorkspace experimental API.

Also some updates on FSharpProjectSnapshot to reflect that we need to be able to efficiently swap referenced projects and files when they change.

Checklist

  • Do we need more [<Experimental>] attributes or is the top level one enough? Should be enough.
  • Test cases added
  • [ ] Performance benchmarks added in case of performance changes
  • [ ] Release notes entry updated

@0101 0101 added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@0101 0101 marked this pull request as ready for review November 20, 2024 16:40
@0101 0101 requested a review from a team as a code owner November 20, 2024 16:40
@edgarfgp
Copy link
Contributor

Thank you for this 👍🏻

@0101
Copy link
Contributor Author

0101 commented Dec 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@0101 0101 merged commit 6a61fc7 into dotnet:main Dec 3, 2024
33 checks passed
@nojaf
Copy link
Contributor

nojaf commented Dec 3, 2024

Thanks @0101 and team!

@0101
Copy link
Contributor Author

0101 commented Dec 3, 2024

@nojaf don't get too excited, this is a pretty early version and didn't go through much testing yet 😅 But do try it out and let us know what needs to be fixed and added!

@nojaf
Copy link
Contributor

nojaf commented Dec 3, 2024

Well, true, but at least it is out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants