Support ValueOption + Struct attribute as optional parameter #18098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
T-Gro
reviewed
Dec 2, 2024
T-Gro
reviewed
Dec 2, 2024
T-Gro
reviewed
Dec 2, 2024
T-Gro
reviewed
Dec 2, 2024
T-Gro
reviewed
Dec 2, 2024
edgarfgp
reviewed
Dec 2, 2024
...ts/Conformance/BasicGrammarElements/MemberDefinitions/OptionalArguments/OptionalArguments.fs
Show resolved
Hide resolved
|
@T-Gro @KevinRansom @0101 this is ready |
edgarfgp
approved these changes
Dec 4, 2024
vzarytovskii
commented
Dec 4, 2024
T-Gro
reviewed
Dec 4, 2024
T-Gro
reviewed
Dec 4, 2024
T-Gro
reviewed
Dec 4, 2024
T-Gro
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Copilot reviewed 13 out of 30 changed files in this pull request and generated no suggestions.
Files not reviewed (17)
- src/Compiler/Checking/CheckDeclarations.fs: Language not supported
- src/Compiler/Checking/CheckPatterns.fs: Language not supported
- src/Compiler/Checking/MethodCalls.fs: Language not supported
- src/Compiler/FSComp.txt: Language not supported
- src/Compiler/Facilities/LanguageFeatures.fs: Language not supported
- src/Compiler/Facilities/LanguageFeatures.fsi: Language not supported
- src/Compiler/TypedTree/TypedTreeOps.fs: Language not supported
- src/Compiler/TypedTree/TypedTreeOps.fsi: Language not supported
- src/Compiler/xlf/FSComp.txt.cs.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.de.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.es.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.fr.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.it.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.ja.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.ko.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.pl.xlf: Language not supported
- src/Compiler/xlf/FSComp.txt.pt-BR.xlf: Language not supported
KevinRansom
approved these changes
Dec 12, 2024
|
@T-Gro I think I have addressed everything. If tests are passing, this is ready. Lemme know if I forgot anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements fsharp/fslang-suggestions#1136 - (fsharp/fslang-suggestions#1136 (comment))
Checklist
I'm not 100% happy with working with attributes as synattributes (though can live with it), though we do it in the graph checking already, but alternative would be abstract option in the compiler and then make a decision during codegen. This will complicate overall checking quite a bit.