Try to fix more of the build script to handle paths with spaces #18143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
Member
|
Thanks, and yes, anything under eng/common should go to arcade. |
vzarytovskii
approved these changes
Dec 13, 2024
T-Gro
approved these changes
Dec 16, 2024
Contributor
|
Hey @jwosty, sorry for the whole experience. Naive question (I'm very bad at PowerShell), won't single quotes somehow help here? I think at least for basic things, they have similar effect as the double ones and that sometimes helps with escaping.
|
Contributor
Author
|
@psfinaki I'm no powershell guru either... I may or may not have given a snippet to chat gpt and asked it how to escape the variables for spaces, lol I don't know. I'm just going to raise the issue in dotnet/arcade since if the problem is really rooted in there it feels silly (to me at least) to try to work around it from here. |
Member
|
I will close this PR for now, it can be reopened if anyone wants to pursue this. |
auto-merge was automatically disabled
August 14, 2025 12:23
Pull request was closed
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #18136
Building works when working with this repo under a path with spaces, but running tests blows up.
Tried to fix it with more quoting (with the contents of this PR), but it seems that Exec-Process in eng/common/tools.ps1 is somehow not handling spaces correctly either. And I guess that file has to be fixed via dotnet/arcade; should I file an issue there?
I'll probably just work out of a directory without spaces at this point 😅