Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix more of the build script to handle paths with spaces #18143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwosty
Copy link
Contributor

@jwosty jwosty commented Dec 13, 2024

Description

Follow up to #18136

Building works when working with this repo under a path with spaces, but running tests blows up.

Tried to fix it with more quoting (with the contents of this PR), but it seems that Exec-Process in eng/common/tools.ps1 is somehow not handling spaces correctly either. And I guess that file has to be fixed via dotnet/arcade; should I file an issue there?

I'll probably just work out of a directory without spaces at this point 😅

@jwosty jwosty requested a review from a team as a code owner December 13, 2024 19:14
Copy link
Contributor

✅ No release notes required

@vzarytovskii
Copy link
Member

Thanks, and yes, anything under eng/common should go to arcade.

@T-Gro T-Gro enabled auto-merge (squash) December 16, 2024 09:33
@psfinaki
Copy link
Member

Hey @jwosty, sorry for the whole experience. Naive question (I'm very bad at PowerShell), won't single quotes somehow help here?

I think at least for basic things, they have similar effect as the double ones and that sometimes helps with escaping.

image

@jwosty
Copy link
Contributor Author

jwosty commented Dec 16, 2024

@psfinaki I'm no powershell guru either... I may or may not have given a snippet to chat gpt and asked it how to escape the variables for spaces, lol

I don't know. I'm just going to raise the issue in dotnet/arcade since if the problem is really rooted in there it feels silly (to me at least) to try to work around it from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants