Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"#if" directive around nullness removed from src/Compiler/Utilities/HashMultiMap.fs #18202

Closed

Conversation

progressive-galib
Copy link
Contributor

@progressive-galib progressive-galib commented Jan 5, 2025

Description

Related: #18061 (partially addresses)

@progressive-galib progressive-galib requested a review from a team as a code owner January 5, 2025 19:55
Copy link
Contributor

github-actions bot commented Jan 5, 2025

❗ Release notes required

@progressive-galib,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'not null' constraint has to be stay there (at least for net90 build), because it is mandated by the inner use of ConcurrentDictionairy for the same generic Key type.

Also, in the compiler codebase, all files come with an .fs implementation file as well as as an corresponding .fsi signature file (with the same core part of the name) => such pairs of files will have to be changed in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants