Type checker: don't suppress errors while checking expressions #18311
Conversation
❗ Release notes required
|
|
Well - 11 tests, that's much less than I would have expected here :) |
| @@ -16,6 +16,7 @@ | |||
| * Add support for C# `Experimental` attribute. ([PR #18253](https://github.com/dotnet/fsharp/pull/18253)) | |||
| * Nullness warnings are issued for signature<>implementation conformance ([PR #18186](https://github.com/dotnet/fsharp/pull/18186)) | |||
| * Symbols: Add FSharpAssembly.IsFSharp ([PR #18290](https://github.com/dotnet/fsharp/pull/18290)) | |||
| * Type checker: don't suppress errors while checking expressions ([PR #18311](https://github.com/dotnet/fsharp/pull/18311)) | |||
There was a problem hiding this comment.
I think we will need better real-life IDE tests and what it does when typing incomplete snippets of code.
I assume there was a reason to suppress typecheck errors in case of parser errors, to prevent a wall of semantic errors jumping around when typing.
I admit the reasons behind it might have changed, but it would be safer if we could either test this more while typing.
auduchinok
force-pushed
the
tcExpr-noErrorSuppress
branch
from
e025765 to
a8c081a
Compare
|
Could someone please help me with updating the baselines here? I've tried committing the files produced during the local tests run, but it doesn't seem to succeed on CI. |
|
This does not look like a baseline issue, all the CI runs today had these failures. EDIT: sorry, forget that, seems to be different |
Fixes #17787.
I guess many tests may need to be updated. 🙂