Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negative [<TailCall>] warning #18399

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Mar 21, 2025

Description

Fix missing analysis for [<TailCall>] violations in TOp.IntegerForLoop expressions appearing as expr1 in Sequential expressions.
As a side effect, this improves the order of warnings, see adjusted test.

Fixes #18365

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

@dawedawe dawedawe requested a review from a team as a code owner March 21, 2025 13:47
Copy link
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@dawedawe dawedawe changed the title Fix 18365 Fix false negative [<TailCall>] warning Mar 21, 2025
@vzarytovskii
Copy link
Member

Sweet, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

False negative with TailCall attribute
2 participants