Reenable a bunch of tests #18991
Merged
Reenable a bunch of tests #18991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
majocha
force-pushed
the
tests-reenable
branch
from
990e471 to
6053578
Compare
majocha
commented
Oct 12, 2025
Contributor
Author
|
I updated the baselines but they need a careful look. Maybe it's worth it to enable these tests for netcore, too. |
majocha
commented
Oct 12, 2025
T-Gro
approved these changes
Oct 13, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out some tests (desktop type check neg tests) were very sneakily disabled for a few months. That's not good.
Now after reenabling them there are 14 failing that require careful look. Some hopefully need trivial baseline updates.