Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting: override method does not match abstract #1950

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

forki
Copy link
Contributor

@forki forki commented Dec 6, 2016

this is first part of a solution for #1430

type Base() =
    abstract member Member: int * string -> string
    default x.Member (i, s) = s

type Derived1() =
    inherit Base()
    override x.Member() = 5

shows:

This override takes a different number of arguments to the corresponding abstract member. The following abstract members were found:
abstract member Base.Member : int * string -> string

@forki forki changed the title WIP Improve error reporting: override method does not match abstract Improve error reporting: override method does not match abstract Dec 7, 2016
@forki
Copy link
Contributor Author

forki commented Dec 7, 2016

ready for review/merge

@forki
Copy link
Contributor Author

forki commented Dec 11, 2016

the error looks unrelated and appveyor succeeded

@KevinRansom
Copy link
Member

@forki

Thanks for taking care of this

Kevin

@KevinRansom KevinRansom merged commit b4901a5 into dotnet:master Dec 14, 2016
@forki forki deleted the i1430 branch December 16, 2016 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants