Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master to VS2017 RC2 #1996

Merged
merged 3 commits into from
Dec 13, 2016
Merged

Update master to VS2017 RC2 #1996

merged 3 commits into from
Dec 13, 2016

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Dec 12, 2016

With Visual Studio 2017 RC2 being released to the public this morning, we can now officially merge the vs2017-rc2 branch into master without breaking everybody else (see the thread in #1967 for context.)

brettfo and others added 2 commits December 8, 2016 08:41
Build was failing, I think this is the right fix
@brettfo brettfo requested review from KevinRansom and dsyme December 12, 2016 19:18
@brettfo brettfo mentioned this pull request Dec 12, 2016
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should update the readme.md to include a note that Dev 15 VS RC2 will be required for building and Testing IDE components.

@brettfo
Copy link
Member Author

brettfo commented Dec 12, 2016

@KevinRansom, I just merged a PR into vs2017-rc2 which updates the docs.

- [Visual Studio 15 SDK](https://www.visualstudio.com/en-us/downloads/visual-studio-next-downloads-vs.aspx)
- [Visual Studio 2017 RC](https://www.visualstudio.com/vs/visual-studio-2017-rc/#downloadvs)
- Under the "Windows" workloads, select ".NET desktop development".
- Select "F# language suport" under the optional components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't you guys promise VS2017 would have C# and VB also as optional components?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In RC1 F# was checked by default in ".NET desktop development" group. I cannot install RC2 since the installer does not work behind the proxy, so I cannot check if it's changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope it was not checked, but I don't know if I'm on RC2 since I'm only seeing "RC" everywhere. Internal version seems to ve 15.0.26009.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

26009 is RC2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forki No, nobody promised that C# and VB would be optional.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I can certainly find a couple of these quotes from VS2015 release phase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all along the lines: "we made that for F# now, but in vnext all languages will be optional because our installer will be so awesome and modular".

Copy link
Contributor

@cartermp cartermp Dec 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of any such quotes, but you're certainly free to raise that issue with appropriate folks. We have no say in this, though.

Something to note is that you could technically follow these same instructions for the "Web" workload, and be just as successful (as it's the .NET Web workload, and F# is also in the same place as .NET Desktop). It's also present in Data Storage and Processing, Xamarin, and Data Science (and the Individual Components tab, but all components are there).

@forki
Copy link
Contributor

forki commented Dec 13, 2016

I tried to run build.cmd vs on this and got:

image

@vasily-kirichenko
Copy link
Contributor

@forki I successfully updated RC to RC2 at home (no proxy server, you know...). Then I merged vs2017-rc2 branch to my find-all-references one and build.cmd vs finished OK. After that I could load VisualFSharp.sln and built it. F5 still does not work, but Ctrl-F5 works OK as before.

Looks like things are in a good state again.

@brettfo brettfo merged commit b4e7eb5 into master Dec 13, 2016
@vasily-kirichenko
Copy link
Contributor

I have the same error on one of my machines

"E:\github\visualfsharp\build-everything.proj" (default target) (1) ->
"E:\github\visualfsharp\vsintegration\fsharp-vsintegration-vsix-build.proj" (Build target) (34) ->
"E:\github\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj" (Build target) (38) ->
(GetVsixDeploymentPath target) ->
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: The "Get ExtensionsPath" task failed unexpectedly.\r [E:\github\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: System.IO. FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.Settings.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken =b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.\r [E:\github\visualfsharp\vsintegration\Vsix\VisualFS harpOpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: File name: 'Microsoft.VisualStudio.Settings.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'\r [E:\github\visualfsharp\vsintegra tion\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: at Micr osoft.VsSDK.Build.Tasks.GetExtensionsPath.Execute()\r [E:\github\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource. csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: at Micr osoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()\r [E:\github\visualfsharp\vsintegration\Vsix\VisualF SharpOpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: at Micr osoft.Build.BackEnd.TaskBuilder.d__26.MoveNext()\r [E:\github\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\V isualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: \r [E:\git hub\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: WRN: Assem bly binding logging is turned OFF.\r [E:\github\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: To enable
assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.\r [E:\github\visualfsharp\vsinte gration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: Note: Ther e is some performance penalty associated with assembly bind failure logging.\r [E:\github\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSourc e\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: To turn th is feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].\r [E:\github\visualfsharp\vsintegration\Vsix\VisualFSharp OpenSource\VisualFSharpOpenSource.csproj]
E:\github\visualfsharp\packages\Microsoft.VSSDK.BuildTools.15.0.25929-RC2\tools\vssdk\Microsoft.VsSDK.targets(612,5): error MSB4018: [E:\githu b\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants