Block Structure service #2011
Merged
Block Structure service #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does it belong to an issue? screenshot? |
|
It works:
I think there are too many blocks, let's discuss what we need and what we don't need. |
|
There are some quirks:
@cloudRoutine could you please looks at it? I remember you handled some ranges in special ways. |
|
sure thing, but I probably won't get to it for a few hours. There were a few bugs in the UAST traversal I never got around to fixing and I wanted to make some adjustments so we can have it filter out the ranges for outlining and block structure simultaneously. |
|
@cloudRoutine thanks! |
|
@dotnet-bot test this please |
|
Thanks for taking care of this Kevin |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* update Microsoft.CodeAnalysis.xxx packages to 2.0.0-rc * add BlockStructureService * BlockStructureService works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP