Improve perf on CollectResults #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
changed the title
forki
force-pushed
the
CollectAtMostOneResult
branch
3 times, most recently
from
3c92ac7 to
7f86562
Compare
forki
changed the title
KevinRansom
requested changes
Dec 15, 2016
| @@ -2193,7 +2199,7 @@ let rec ResolveExprLongIdentPrim sink (ncenv:NameResolver) fullyQualified m ad n | |||
| if List.isEmpty tcrefs then NoResultsOrUsefulErrors else | |||
| let tcrefs = tcrefs |> List.map (fun tcref -> (resInfo,tcref)) | |||
| let tcrefs = CheckForTypeLegitimacyAndMultipleGenericTypeAmbiguities (tcrefs, TypeNameResolutionInfo.ResolveToTypeRefs (TypeNameResolutionStaticArgsInfo.Indefinite), PermitDirectReferenceToGeneratedType.No, unionRanges m id.idRange) | |||
| ResolveLongIdentInTyconRefs ncenv nenv LookupKind.Expr 1 m ad rest typeNameResInfo id.idRange tcrefs | |||
| ResolveLongIdentInTyconRefs true ncenv nenv LookupKind.Expr 1 m ad rest typeNameResInfo id.idRange tcrefs | |||
There was a problem hiding this comment.
Can we use an enum for at most 1, true is a tad tricky to read?
There was a problem hiding this comment.
Yes would have done this anyways. But you are definitely right
| (ResolveTypeLongIdentInModuleOrNamespace ncenv typeNameResInfo ad genOk) | ||
| |?> List.concat | ||
|
|
||
| let modulSearchFailed() = | ||
| ResolveLongIndentAsModuleOrNamespaceThen ncenv.amap m fullyQualified nenv AccessibleFromSomeFSharpCode lid | ||
| ResolveLongIndentAsModuleOrNamespaceThen false ncenv.amap m fullyQualified nenv AccessibleFromSomeFSharpCode lid |
|
@dotnet-bot test this. failures are not related. |
|
I'm trying to measure this and it's not making huge impact as is on a full compile. But from what I can in VS debug it's definitely doing a lot less work for name resolution. This is especially important for suggestion errors. |
forki
force-pushed
the
CollectAtMostOneResult
branch
from
90f4fc8 to
293b69b
Compare
|
made it an emu |
|
Wow didn't expect this to be merged so fast. @dsyme could you please take a
look as well?
Am 15.12.2016 9:43 nachm. schrieb "Kevin Ransom (msft)" <
notifications@github.com>:
Merged #2018 <#2018>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2018 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADgNCJH4q4x5S5DOma1WgtzdcEhy_19ks5rIaaMgaJpZM4LOFN_>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where we can cut the name resolution