Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup error handling #2021

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Cleanup error handling #2021

merged 1 commit into from
Dec 15, 2016

Conversation

forki
Copy link
Contributor

@forki forki commented Dec 15, 2016 

 if nReqd > nActual then

was checked twice and pattern matching was "not nice"

KevinRansom
KevinRansom approved these changes Dec 15, 2016
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I believe the new code is nicer or even ... easier to read. But the old gold was certainly ugly too.

@forki
Copy link
Contributor Author

forki commented Dec 15, 2016

yeah this code is definetly no beauty. but now we have one conditions less and create couple of objects less. small things...

@KevinRansom KevinRansom merged commit 86410d7 into dotnet:master Dec 15, 2016
@forki forki deleted the cleanerror branch December 16, 2016 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forki @KevinRansom @msftclas