Force update project options when assembly references change #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oky I think I fished the assembly reference thing again ... packages.config got overwritten. |
KevinRansom
requested changes
Dec 16, 2016
| @@ -207,13 +207,15 @@ type internal FSharpLanguageService(package : FSharpPackage) as this = | |||
| let projectInfoManager = this.Package.ComponentModel.DefaultExportProvider.GetExport<ProjectInfoManager>().Value | |||
|
|
|||
| /// Sync the information for the project | |||
| member this.SyncProject(project: AbstractProject, projectContext: IWorkspaceProjectContext, site: IProjectSite) = | |||
| member this.SyncProject(project: AbstractProject, projectContext: IWorkspaceProjectContext, site: IProjectSite, forceUpdate) = | |||
There was a problem hiding this comment.
Could we make forceUpdate and enum please, true isn't really readable.
There was a problem hiding this comment.
SyncProject is a class member with two usages at the same file. At the both call sites, I have used named parameters for forceUpdate. I don't think changing bool to two-case enums would improve readability here.
There was a problem hiding this comment.
Thanks for taking care of this
Kevin
KevinRansom
approved these changes
Dec 16, 2016
|
Awesome. Thanks, @dungpa! |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…2023) * Force update project options when assembly references change. Fix dotnet#2020. * Fix merge issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2020.