Better lexer symbol #2056
Merged
Better lexer symbol #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 19, 2016 15:47
forki
reviewed
Dec 19, 2016
| /// Gets the value associated with the option or the supplied default value. | ||
| let inline getOrElse v = function | ||
| | Some x -> x | None -> v | ||
|
|
||
| /// Gets the option if Some x, otherwise try to get another value | ||
| let inline orTry f = |
There was a problem hiding this comment.
these are in the FSharp.Core now, right? (just as possible optimization)
There was a problem hiding this comment.
No they are not. I could not compile without these helpers.
|
@dotnet-bot test this please |
|
The options module has some additions, the names are a bit different from the ones you used: Hope this helps Kevin |
remove Pervasive.fs
|
Done. |
KevinRansom
approved these changes
Dec 20, 2016
|
Thanks for taking care of this Kevin |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* port lexer symbol lookup logic from VFPT and use it in DocumentHighlightsService * QuickInfoProvider uses lexer symbol * remove tryClassifyAtPosition * do not show quick info if FCS return a list of single FSharpTooltipElement.None * use standard Option combinators remove Pervasive.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is (partially) ported from VFPT and it's main goal is to find proper range of a symbol at position. The previous implementation was buggy, it returned wrong ranges for operators and type parameters.