Defer getting all entities as much as possible #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Dec 21, 2016
|
I'm not sure it's needed because this code fix is activated on 039 error only. |
|
Ok, it might be needed if you extend to more error codes. I'm closing the PR then. |
|
Please don't close. It still looks sane. |
|
Yes, it looks OK. However, I was thinking about the opposite thing: loading entities from all assemblies in background to make the light bulb appear immediately the first time. |
|
@dungpa Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to ensure that getting all entities (the most expensive operation) is only called if the symbol under cursor is valid.
/cc @vasily-kirichenko