Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FS-1030] - Anonymous records #2671

Closed
wants to merge 190 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
190 commits
Select commit Hold shift + click to select a range
0170389
anon
dsyme Mar 3, 2017
92a1aed
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 8, 2017
f084288
basic property access
dsyme Mar 16, 2017
7458be2
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 16, 2017
eb27f17
simplify struct syntax
dsyme Mar 16, 2017
b4bb4ab
simplify struct syntax
dsyme Mar 16, 2017
b5771ae
syntax {| new ... |}
dsyme Mar 16, 2017
e1815ee
build fixes
dsyme Mar 16, 2017
afe95ff
fix build
dsyme Mar 17, 2017
47d7a13
fix syntax
dsyme Mar 17, 2017
69965c2
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 20, 2017
dd38b9e
generate types and cross-assembly support
dsyme Mar 20, 2017
ddc8d9a
share nodes in pickle format
dsyme Mar 21, 2017
ee704ac
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 21, 2017
f9ea73c
add smoke tests
dsyme Mar 21, 2017
d7f003f
fix proto build
dsyme Mar 21, 2017
08435e2
fix proto build
dsyme Mar 21, 2017
77a02e0
fix proto build
dsyme Mar 21, 2017
4254d72
fix proto build
dsyme Mar 21, 2017
d2665fe
fix proto build
dsyme Mar 21, 2017
180092c
fix equality/comparison/record-display-and-formatting
dsyme Mar 23, 2017
e14823d
Update IlxGen.fs
dsyme Mar 23, 2017
b2d799f
remove kind A anon records
dsyme Mar 24, 2017
6fe2768
update tests and implementation for cases where anon types occur only…
dsyme Mar 24, 2017
16376c0
completion
dsyme Mar 24, 2017
d3e9393
completion
dsyme Mar 24, 2017
03dc91e
fix build
dsyme Mar 24, 2017
8274d19
fix symbols
dsyme Mar 24, 2017
d6d214e
merge master
dsyme Apr 5, 2017
473b2d7
merge
dsyme Apr 28, 2017
5a5c88e
integrate with master
dsyme Jun 17, 2017
dcf869f
integrate with master
dsyme Jun 17, 2017
517e4eb
integrate with master
dsyme Jun 17, 2017
a5904a3
Merge branch 'master' into anon-1
dsyme Aug 18, 2017
d4ff140
integrate master
dsyme Sep 5, 2017
e69503e
integrate master
dsyme Sep 5, 2017
9958e32
integrate master
dsyme Sep 5, 2017
a146b89
integrate master
dsyme Sep 5, 2017
80533e6
integrate with master
Dec 1, 2017
db6acf0
integrate with master
Dec 1, 2017
8f63e88
Merge remote-tracking branch 'remotes/origin/master' into anon-1
realvictorprm Dec 28, 2017
259fd47
Merge pull request #12 from realvictorprm/anon-1
dsyme Jan 5, 2018
b334583
Symbols API: add IsNameGenerated to FSharpField
auduchinok Jan 19, 2018
603b71d
Change error text.
isaacabraham Jan 20, 2018
051fc59
update loc
Jan 22, 2018
6cb64f2
Add support for easy DesignTime Assembly Packing (#4239)
KevinRansom Jan 23, 2018
488e71c
It looks like we can get rid of some Some (#4244)
forki Jan 24, 2018
4f39f97
Merge pull request #4229 from isaacabraham/2307-protected-member-erro…
KevinRansom Jan 24, 2018
203d70e
show type of ignored expression (#4197)
dsyme Jan 24, 2018
09fc352
[WIP] Fix inlline rename at end of file (#3766)
vasily-kirichenko Jan 24, 2018
d70a450
Get declaration list symbols (#4204)
nosami Jan 24, 2018
e2af0fa
Fix CI. fixes #4256 (#4257)
nosami Jan 24, 2018
5728b68
Improve compiler designtime probing (#4250)
KevinRansom Jan 25, 2018
e2168fa
Enable preferreduilang for fsi (#4253)
KevinRansom Jan 29, 2018
bca446d
Fix the Mono and OSX builds (#4273)
dsyme Jan 29, 2018
65506e9
use dev15.5 for CI builds
brettfo Jan 29, 2018
5d88640
Merge pull request #4283 from brettfo/jenkins-image
brettfo Jan 29, 2018
8bfe56e
enable Microsoft.DiaSymReader* packages to be overridden during build
brettfo Feb 1, 2018
d771ea5
LOC CHECKIN | visualfsharp master | 20180202
v-zbsail Feb 2, 2018
ecb833c
Update README.md
cartermp Feb 2, 2018
b9d4942
Merge pull request #4299 from brettfo/dependency-uptake
brettfo Feb 2, 2018
58c4e60
Merge pull request #4304 from v-zbsail/loc_20180129_master
brettfo Feb 2, 2018
02cb8cd
restore tools before dependency uptake work
brettfo Feb 2, 2018
71fcc34
Merge pull request #4306 from brettfo/build-tools-order
brettfo Feb 2, 2018
19dd0df
propagate Microsoft.DiaSymReader* version overrides to NuGet packages
brettfo Feb 5, 2018
8f4f2ae
Merge pull request #4314 from brettfo/dependency-uptake-nuspec
brettfo Feb 5, 2018
ac2d8d5
miscfiles (#4328)
KevinRansom Feb 9, 2018
5c491b2
Improve warning for ignored values in sequence expressions - fixes #4…
forki Feb 9, 2018
bc7ce19
Remove minimumElement and maximumElement from Set module (#4309)
PatrickMcDonald Feb 11, 2018
78ea65d
only publish Microsoft.FSharp.Compiler.* package to the blob feed
brettfo Feb 13, 2018
a1c55cf
Merge pull request #4349 from brettfo/blob-publish
brettfo Feb 13, 2018
7377b02
Revert #4173 (i.e. reapply #1650 and #3366)" (#4347)
dsyme Feb 13, 2018
32307bc
Update README.md (#4351)
dsyme Feb 13, 2018
a12c05c
Removed NoSourceCode at GetDeclarationLocation (#4277)
amieres Feb 14, 2018
be5b58c
Merge pull request #4225 from auduchinok/record-fields-name-generated
KevinRansom Feb 17, 2018
2180de4
Optimize in FCS (#3784)
forki Feb 17, 2018
3d0ae5e
[WIP] simplify mono build (#4358)
dsyme Feb 17, 2018
e1a6afa
Update DEVGUIDE.md
dsyme Feb 17, 2018
f53f536
use the official build number (if provided) to version the compiler p…
brettfo Feb 17, 2018
828fb11
Merge pull request #4361 from brettfo/nuget-version
brettfo Feb 20, 2018
02dbf9e
Reduce FCS memory footprint (#4272)
AviAvni Feb 21, 2018
3db878f
Enable --debug:full on coreclr (#4366)
KevinRansom Feb 21, 2018
e1e4cce
Remove FSharp.Editor dependency on FSharp.Language Service redux (#4132)
cartermp Feb 22, 2018
689da32
LOC CHECKIN | visualfsharp master | 20180222
v-zbsail Feb 22, 2018
2b44f64
Add support for UnmanagedType.LPUTF8Str (#4360)
BillHally Feb 22, 2018
2b52d90
Merge pull request #4370 from v-zbsail/loc_20180220_master
brettfo Feb 22, 2018
570e5aa
Update netci.groovy (#4371)
dsyme Feb 22, 2018
814aa75
Update netci.groovy (#4373)
dsyme Feb 22, 2018
ce36262
Update netci.groovy
dsyme Feb 22, 2018
0bdad51
Use mutli-line string (#4374)
mmitche Feb 22, 2018
e0203f0
rejig netci.groovy (#4377)
dsyme Feb 22, 2018
1caefc1
Update netci.groovy
dsyme Feb 22, 2018
b26d549
Update netci.groovy
dsyme Feb 22, 2018
929b8c3
Updates to CI (#4381)
dsyme Feb 22, 2018
19ce02d
Allow sudo on CI Ubuntu to install latest Mono (#4382)
dsyme Feb 22, 2018
7fe3465
fix casing of FCS outputs (#4383)
dsyme Feb 22, 2018
4a7575b
No longer sudo as no outer-latest jobs are being executed in CI (#4384)
dsyme Feb 23, 2018
d688e0f
Update netci.groovy
dsyme Feb 23, 2018
509a8a2
simplify defines and move FCS to .NET Standard 2.0 (#4368)
dsyme Feb 23, 2018
161b3c2
Update netci.groovy
dsyme Feb 23, 2018
2d0452a
move NuGet.Config to the root
brettfo Jan 24, 2018
7b1d303
remove '-proto' file name suffixes
brettfo Jan 25, 2018
a37642b
update xlf plugin
brettfo Feb 7, 2018
b280da9
convert FSharp.Editor to the dotnet SDK
brettfo Feb 5, 2018
204fa02
convert FSharp.LanguageService to the dotnet SDK
brettfo Feb 7, 2018
f1884fc
convert FSharp.ProjectSystem.FSharp to the dotnet SDK
brettfo Feb 8, 2018
bff5665
convert FSharp.VS.FSI to the dotnet SDK
brettfo Feb 8, 2018
1b6a9cf
convert FSharp.LanguageService.Base to the dotnet SDK
brettfo Feb 8, 2018
daacde6
convert FSharp.ProjectSystem.Base to the dotnet SDK
brettfo Feb 9, 2018
9586ecd
convert FSharp.UIResources to the dotnet SDK
brettfo Feb 10, 2018
b921e22
set OutputPath after TargetFramework
brettfo Feb 22, 2018
d244507
generate NuGet package version from #4350
brettfo Feb 22, 2018
b8a36be
fix package versions
brettfo Feb 22, 2018
ecf4ba8
fix design-time builds in VSSDK projects that don't produce a VSIX
brettfo Feb 22, 2018
a44472c
Merge pull request #4317 from brettfo/sdk-proj
brettfo Feb 23, 2018
ab0da53
update paket bootstrapper (#4388)
dsyme Feb 23, 2018
9404e9c
update CI to allow sudo on Ubuntu (#4392)
dsyme Feb 24, 2018
9687654
Test CI after https://github.com/Microsoft/visualfsharp/pull/4392
dsyme Feb 24, 2018
7131143
get latest mono in CI (#4394)
dsyme Feb 24, 2018
2c3cfbf
fix tuple warnings (#4389)
dsyme Feb 24, 2018
44ef814
Fix 4240 - MakeTuple on struct tuples (#4387)
dsyme Feb 25, 2018
e7ce9cd
Re-enable FCS build on Jenkins Ubuntu (#4391)
dsyme Feb 27, 2018
1605352
Fix build and test issues (#4396)
KevinRansom Feb 27, 2018
fb54266
convert FSharp.PropertyPages to use PackageReference
brettfo Feb 28, 2018
8b2d732
Update feed tasks version
mmitche Feb 28, 2018
fa80142
Remove unsupported `-c` switch from `dotnet restore`
brettfo Feb 28, 2018
551613c
Merge pull request #4409 from Microsoft/remove-proto-config
brettfo Feb 28, 2018
a50f4c5
Debugger View for lists (#4399)
KevinRansom Feb 28, 2018
e0ce4a4
consolidate Directory.Build.props/.targets
brettfo Feb 28, 2018
3f42446
Merge pull request #4406 from brettfo/propertypages-packagereference
brettfo Feb 28, 2018
b6cce2c
convert `vsintegration/tests` to the dotnet SDK
brettfo Feb 28, 2018
dfd6b2e
consolidate Roslyn versions to `RoslynPackageVersion.txt`
brettfo Feb 28, 2018
fa9fa49
Add DesignTimeBuild=true to legacy build from ProjectSystem (#4407)
KevinRansom Mar 1, 2018
f697a7d
Reduce memory footprint for Val type (#4375)
AviAvni Mar 1, 2018
d812517
Merge pull request #4410 from brettfo/salsa-sdk
brettfo Mar 1, 2018
ee2927d
convert item template projects to the dotnet SDK
brettfo Mar 1, 2018
668825a
convert project template projects to the dotnet SDK
brettfo Mar 1, 2018
2a7188c
Merge pull request #4411 from brettfo/template-sdk
brettfo Mar 1, 2018
cb2990e
Update feed tasks version
mmitche Mar 1, 2018
59fadd0
convert LanguageServiceProfiling to the dotnet SDK
brettfo Mar 1, 2018
c0ac091
Merge pull request #4408 from mmitche/update-tasks-and-such
brettfo Mar 1, 2018
226ca53
convert VisualFSharpTemplates to the dotnet SDK
brettfo Mar 1, 2018
be22484
convert VisualFSharpOpenSource to the dotnet SDK
brettfo Mar 1, 2018
4314d69
convert VisualFSharpFull to the dotnet SDK
brettfo Mar 1, 2018
2296c2b
cleanup Directory.Build.props/.targets and remove packages.config
brettfo Mar 1, 2018
f214dcc
Merge pull request #4417 from brettfo/vsix-sdk
brettfo Mar 2, 2018
bfdc9d0
Merge remote-tracking branch 'upstream/dev15.6' into merges/dev15.6-t…
brettfo Mar 2, 2018
a98b806
upgrade System.ValueTuple to 4.4.0 (asm ver 4.0.2.0)
brettfo Mar 5, 2018
0dbb19b
fix usage of <DeployExtension>
brettfo Mar 5, 2018
0adb823
Merge pull request #4425 from Microsoft/merges/dev15.6-to-master
brettfo Mar 6, 2018
4462b3a
consolidate assembly attribute writing
brettfo Mar 6, 2018
a044057
don't try to invoke fsi.exe if it wasn't built
brettfo Mar 6, 2018
a15c1f4
ensure all resources assemblies get shipped
brettfo Mar 6, 2018
9e7a610
Merge pull request #4450 from brettfo/assembly-attributes
brettfo Mar 6, 2018
f21648e
Merge pull request #4451 from brettfo/assembly-version-check
brettfo Mar 6, 2018
ba9b757
Merge pull request #4452 from brettfo/editor-resources
brettfo Mar 6, 2018
3188acf
restore SDK projects after proto has been built
brettfo Mar 6, 2018
beadbdb
Merge pull request #4453 from brettfo/restore-order
brettfo Mar 7, 2018
970c0fe
fixes typos (#4459)
forki Mar 7, 2018
29a3bdd
Faster check if IsExtensionMember (#4458)
forki Mar 7, 2018
3d17049
Add instructions to install fsharp to custom user defined path; fix a…
boloutaredoubeni Mar 7, 2018
214475e
small cleanup in TProvidedNamespaceExtensionPoint (#4441)
forki Mar 7, 2018
b7c2099
Reduce intermediate collections when checking symboluse (#4442)
forki Mar 7, 2018
f1e781c
shortcut singleton list in append (#4445)
forki Mar 7, 2018
51dac00
Couple of cleanups in ErrorLogger (#4433)
forki Mar 7, 2018
2e43924
ensure build outputs always go to `$(Configuration)\$(TargetDotnetPro…
brettfo Mar 7, 2018
be1877c
use VS version as base for insertion packages
brettfo Mar 7, 2018
2c9030d
Merge pull request #4454 from brettfo/outputpath
brettfo Mar 7, 2018
f1a9088
remove the `Proto` configuration from VisualFSharp.sln
brettfo Mar 7, 2018
7cc4cfa
Merge pull request #4464 from brettfo/vs-f5
brettfo Mar 7, 2018
3fc5e6d
Merge pull request #4463 from brettfo/product-version
brettfo Mar 7, 2018
f5e05e8
add the commit hash to the description of shipping NuGet packages
brettfo Mar 8, 2018
25ee345
add the commit hash to the VS package
brettfo Mar 9, 2018
da5d0f6
One lookup in nenv.eFieldLabels should be enough (#4469)
forki Mar 9, 2018
792dbe5
Shortcut NameResolution searches (#4444)
forki Mar 9, 2018
ed8393c
No need to decompile coreDisplayName all the time (#4443)
forki Mar 9, 2018
e4fb0fc
small cleanups in MethodCalls.fs (#4435)
forki Mar 9, 2018
bbf07fb
List.isEmpty instead of iterating through the list to get the count (…
forki Mar 9, 2018
1a3f1e8
try to minimize intermediate NameRes environments (#4440)
forki Mar 9, 2018
aee2fa8
Merge pull request #4474 from brettfo/package-commit-hash
brettfo Mar 9, 2018
47e74f5
Toggles for outlining and structured guidelines (#4227)
cartermp Mar 9, 2018
d49f3dd
fix cancellation for PostAndAsyncReply (#4477)
dsyme Mar 9, 2018
f5992a7
consolidate Newtonsoft.Json version to match what's shipped in VS
brettfo Mar 8, 2018
33159e8
Merge pull request #4479 from Microsoft/newtonsoft-json-version
brettfo Mar 9, 2018
360b52e
integrate master
dsyme Mar 9, 2018
3fb44a4
Remove dependency on FSharp.LanguageService from FSharp.ProjectSystem…
cartermp Mar 9, 2018
d7274c6
Clean up illib (#4428)
forki Mar 10, 2018
4952f84
Move basex1 and basey1 down (#4491)
forki Mar 12, 2018
2521f81
Equality is 0 (#4493)
forki Mar 12, 2018
352a030
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 12, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
It looks like we can get rid of some Some (#4244)
forki authored and KevinRansom committed Jan 24, 2018
commit 488e71c400218a0246d9766c263895e0b52c4182
19 changes: 9 additions & 10 deletions src/fsharp/TypeChecker.fs
Original file line number Diff line number Diff line change
@@ -793,8 +793,8 @@ let UnifyFunctionType extraInfo cenv denv mFunExpr ty =
| None -> error (FunctionExpected(denv, ty, mFunExpr))

let ReportImplicitlyIgnoredBoolExpression denv m ty expr =
let checkExpr m exprOpt =
match exprOpt with
let checkExpr m expr =
match expr with
| Expr.App(Expr.Val(vf, _, _), _, _, exprs, _) when vf.LogicalName = opNameEquals ->
match exprs with
| Expr.App(Expr.Val(propRef, _, _), _, _, Expr.Val(vf, _, _) :: _, _) :: _ ->
@@ -821,17 +821,16 @@ let ReportImplicitlyIgnoredBoolExpression denv m ty expr =
| _ -> UnitTypeExpected (denv, ty, m)

match expr with
| Some(Expr.Let(_, Expr.Sequential(_, inner, _, _, _), _, _))
| Some(Expr.Sequential(_, inner, _, _, _)) ->
| Expr.Let(_, Expr.Sequential(_, inner, _, _, _), _, _)
| Expr.Sequential(_, inner, _, _, _) ->
let rec extractNext expr =
match expr with
| Expr.Sequential(_, inner, _, _, _) -> extractNext inner
| _ -> checkExpr expr.Range expr
extractNext inner
| Some expr -> checkExpr m expr
| _ -> UnitTypeExpected (denv, ty, m)
| expr -> checkExpr m expr

let UnifyUnitType cenv denv m ty exprOpt =
let UnifyUnitType cenv denv m ty expr =
if AddCxTypeEqualsTypeUndoIfFailed denv cenv.css m ty cenv.g.unit_ty then
true
else
@@ -843,7 +842,7 @@ let UnifyUnitType cenv denv m ty exprOpt =
if not (typeEquiv cenv.g cenv.g.bool_ty ty) then
warning (UnitTypeExpected (denv, ty, m))
else
warning (ReportImplicitlyIgnoredBoolExpression denv m ty exprOpt)
warning (ReportImplicitlyIgnoredBoolExpression denv m ty expr)
false

//-------------------------------------------------------------------------
@@ -5568,7 +5567,7 @@ and TcStmtThatCantBeCtorBody cenv env tpenv expr =
and TcStmt cenv env tpenv synExpr =
let expr, ty, tpenv = TcExprOfUnknownType cenv env tpenv synExpr
let m = synExpr.Range
let wasUnit = UnifyUnitType cenv env.DisplayEnv m ty (Some expr)
let wasUnit = UnifyUnitType cenv env.DisplayEnv m ty expr
if wasUnit then
expr, tpenv
else
@@ -10414,7 +10413,7 @@ and TcNormalizedBinding declKind (cenv:cenv) env tpenv overallTy safeThisValOpt
else TcExprThatCantBeCtorBody cenv overallExprTy envinner tpenv rhsExpr)

if bkind = StandaloneExpression && not cenv.isScript then
UnifyUnitType cenv env.DisplayEnv mBinding overallPatTy (Some rhsExprChecked) |> ignore<bool>
UnifyUnitType cenv env.DisplayEnv mBinding overallPatTy rhsExprChecked |> ignore<bool>

// Fix up the r.h.s. expression for 'fixed'
let rhsExprChecked =