CompileOps.qnameOrder uses full file path without extension to compare instead of module name inferred from file name

[vasily-kirichenko]

I fixes #2679

@dsyme I'm not sure I've not broken something. It should still work for sig + impl pairs because I compare by full file name without signature.

[dsyme]

It looks OK though I haven't looked at the CI failure

[vasily-kirichenko]

@dsyme I've looked :) Some of the failures

Errors and Failures

1) Failed : FSharp.Test.FSharpSuite.TypeProviderTests.diamondAssembly
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsi.exe' with args '-r:System.Core.dll --nowarn:20  --define:INTERACTIVE --maxerrors:1 --abortonerror test3.fsx' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typeProviders\diamondAssembly'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at TestFramework.exec@428-22.Invoke(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 428
at TestFramework.fsi@447-3.Invoke(String flags, FSharpList`1 sources) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 447
at FSharp.Test.FSharpSuite.TypeProviderTests.diamondAssembly() in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\TypeProviderTests.fs:line 63

2) Failed : FSharp.Test.FSharpSuite.TypeProviderTests.helloWorld fsi
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsi.exe' with args ' ' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typeProviders\helloWorld'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at TestFramework.execStdin@434-1.Invoke(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 434
at TestFramework.fsiStdin@454-1.Invoke(String flags, FSharpList`1 sources) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 454
at SingleTest.singleTestBuildAndRunCore(TestConfig cfg, String copyFiles, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 103
at FSharp.Test.FSharpSuite.TypeProviderTests.helloWorld(Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\TypeProviderTests.fs:line 101

3) Failed : FSharp.Test.FSharpSuite.TypeProviderTests.wedgeAssembly
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsc.exe' with args '-r:System.Core.dll --nowarn:20 --define:COMPILED --debug+ -r:provider.dll --optimize- -o:test2a-with-sig-restricted.dll -a test2a-restricted.fsi test2a.fs' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typeProviders\wedgeAssembly'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at TestFramework.exec@428-22.Invoke(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 428
at TestFramework.fsc@436-1.Invoke(String flags, FSharpList`1 srcFiles) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 436
at FSharp.Test.FSharpSuite.TypeProviderTests.wedgeAssembly() in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\TypeProviderTests.fs:line 291

4) Failed : FSharp-Tests-Core+CoreTests.attributes-FSI_BASIC
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsi.exe' with args '-r:System.Core.dll --nowarn:20  --define:INTERACTIVE --maxerrors:1 --abortonerror testlib.fsi testlib.fs test.fsx' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\core\attributes'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at TestFramework.exec@428-22.Invoke(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 428
at TestFramework.fsi@447-3.Invoke(String flags, FSharpList`1 sources) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 447
at SingleTest.singleTestBuildAndRunCore(TestConfig cfg, String copyFiles, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 95
at SingleTest.singleTestBuildAndRun(String dir, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 172

No idea how it's related. I re-run the build, same failures.

[vasily-kirichenko]

I have no interest to finish it, sorry.