Fix some assertions in debug mode #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saul
suggested changes
May 9, 2017
| @@ -13,7 +13,7 @@ open Microsoft.CodeAnalysis.Text | |||
| open Microsoft.CodeAnalysis.CodeFixes | |||
| open Microsoft.CodeAnalysis.CodeActions | |||
|
|
|||
| [<ExportCodeFixProvider(FSharpConstants.FSharpLanguageName, Name = PredefinedCodeFixProviderNames.SimplifyNames); Shared>] | |||
| //[<ExportCodeFixProvider(FSharpConstants.FSharpLanguageName, Name = PredefinedCodeFixProviderNames.SimplifyNames); Shared>] | |||
There was a problem hiding this comment.
I assume you didn't mean to disable this? There's an option for this in the options dialog.
There was a problem hiding this comment.
Thanks :) I'll re-enable it. However see also #3009
added 3 commits
May 9, 2017 16:33
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
WHile fixing dotnet#2793 I improved the diagnostics for some assertions and remove some exceptions that were happening on the startup path I also cleaned up the logic for BinFolderOfDefaultFSharpCompiler a little and take advantage of the fact that optdata/sigdata are gone to simplify some things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHile fixing #2793 I improved the diagnostics for some assertions and remove some exceptions that were happening on the startup path
I also cleaned up the logic for
BinFolderOfDefaultFSharpCompilera little and take advantage of the fact that optdata/sigdata are gone to simplify some things.