Fix for #8 - regression in autocompete

[dsyme]

This is a potential fix for the regression #8. I prototyped the fix as a change to the F# Compiler Service (which is somewhat easier to test as a component since you can script tests with F# Interactive).

I'm gradually building and running tests though it's challenging (it's a fix to intellisense, my VS CTP5 has expired, and I'm on a slowish connection so can't get VS CTP6).

Submitting here to get a validation of the build and to make it available for further testing.

[dsyme]

@latkin @KevinRansom - I tried to run the "ideunit" tests but got lots and lots of errors, I'm sure unrelated to the fix (they were about failing casts related VS components).

I'm pretty sure I followed the instructions exactly as in DEVGUIDE.md and TESTGUIDE.md, I did this:

    msbuild src/fsharp-library-build.proj  /p:Configuration=Release
    msbuild src/fsharp-compiler-build.proj  /p:Configuration=Release
    msbuild src/fsharp-typeproviders-build.proj  /p:Configuration=Release
    msbuild src/fsharp-compiler-unittests-build.proj  /p:Configuration=Release
    msbuild src/fsharp-library-build.proj /p:TargetFramework=net20 /p:Configuration=Release
    msbuild src/fsharp-library-build.proj /p:TargetFramework=portable47 /p:Configuration=Release
    msbuild src/fsharp-library-build.proj /p:TargetFramework=portable7 /p:Configuration=Release
    msbuild src/fsharp-library-build.proj /p:TargetFramework=portable78 /p:Configuration=Release
    msbuild src/fsharp-library-build.proj /p:TargetFramework=portable259 /p:Configuration=Release
    msbuild src/fsharp-library-unittests-build.proj  /p:Configuration=Release
    msbuild src/fsharp-library-unittests-build.proj /p:TargetFramework=portable47 /p:Configuration=Release
    msbuild src/fsharp-library-unittests-build.proj /p:TargetFramework=portable7 /p:Configuration=Release
    msbuild src/fsharp-library-unittests-build.proj /p:TargetFramework=portable78 /p:Configuration=Release
    msbuild src/fsharp-library-unittests-build.proj /p:TargetFramework=portable259 /p:Configuration=Release
    src\update.cmd release -ngen
    tests\BuildTestTools.cmd release 
    msbuild vsintegration\fsharp-vsintegration-build.proj /p:Configuration=Release
    msbuild vsintegration\fsharp-vsintegration-unittests-build.proj /p:Configuration=Release
    RunTests.cmd release ideunit

If you could either run the tests or double check the "ideunit" instructions I'd be very grateful.

thanks
don

[latkin]

I have trouble running unit tests against VS 12.0 on my box with 12.0 and 14.0, also lots of unhelpful casting errors.

Assuming you want to test this against VS 2015 SDK, you should to double-check that you are building with MSBuild 14.0, so that all of the 14.0 SDK assemblies are referenced.

In the meantime, I'll try running this myself soon.

[dsyme]

ok, I see, thanks

[latkin]

I can confirm that the unit tests now pass 🎉

[dsyme]

Great - I got them to pass on my machine too. Party party party.