undo #3536 #3746
Merged
undo #3536 #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2017 10:59
|
cc @Pilchie This fixes a regression in the F# compiler that has broken people. I'll file the internal bug for shiproom. |
Merged
KevinRansom
pushed a commit
to KevinRansom/fsharp
that referenced
this pull request
Oct 18, 2017
* undo dotnet#3536 * undo dotnet#3536
|
@dsyme Can we publish the latest fix here to https://www.nuget.org/packages/FSharp.Compiler.Tools/ ? |
|
@cartermp yes, will do |
|
Great!
|
|
4.1.29 was published and it does not have this bug. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cartermp Bug #3743 is a regression
This disables the optimization that causes the regression #3536. The testing of the optimization was flawed, in particular the code https://github.com/Microsoft/visualfsharp/pull/3536/files#diff-ebddd0dd8ddd9195acef989b49ecfb67R542 has
x > 0when it should havex = 0which means that the recursive calls were not being made in the tests.We should prioritize this as much as possible, e.g. into 15.5 escrow if that's feasible
thanks
don