Assume COMPILER_PUBLIC_API #4120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding is that there doesn't seem any specific value in continuing to require that COMPILER_PUBLIC_API be set - we can just assume that it's always set
It really gets in the way of coding and designing the public surface area of FCS
We want to move to eventually - one day - have the VIsual F# Tools use FSharp.Compiler.Service.dll.
Currently we build
FSharp.Compiler.Private.dllwhere COMPILER_PUBLIC_API is not set. But it turns out this DLL has always had a good number of public types, see below. So we may as well just align now and keep our life simple.Privatein the name).