Clean up illib #4428
Clean up illib #4428
Conversation
forki
force-pushed
the
cleanup
branch
3 times, most recently
from
8a00ce1 to
e26f462
Compare
|
done with this one |
src/fsharp/NicePrint.fs
Outdated
| @@ -1275,7 +1277,7 @@ module InfoMemberPrinting = | |||
| let paramDatas = minfo.GetParamDatas(amap, m, minst) | |||
| let layout = | |||
| layout ^^ | |||
| if isNil (List.concat paramDatas) then | |||
| if Seq.isEmpty (Seq.concat paramDatas) then | |||
There was a problem hiding this comment.
Please don't introduce Seq in the compiler unless there is a specific perf measurement, for much the same reasons as mentioned in other PR. I know there is an intermediate allocation, but ...
There was a problem hiding this comment.
In this case it's not because of the intermediate allocation, but because it may will exit on very first item in paramDatas instead of concat and then throwing it away. But I can rewrite that as List.exists (not isNil) paramDatas
There was a problem hiding this comment.
In this case it's not because of the intermediate allocation, but because it may will exit on very first item in paramDatas instead of concat and then throwing it away. But I can rewrite that as List.exists (not isNil) paramDatas
|
Approved apart from the one thing i mentioned with Seq creeping in |
|
Fixing a single line from mobile phone. How hard can it be? |
|
Ok looks good now and much better than Seq. |
No description provided.