New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cancellation for PostAndAsyncReply #4477

Merged

KevinRansom merged 2 commits into dotnet:master from dsyme:cancel1

Mar 9, 2018

Contributor

dsyme commented Mar 9, 2018

Fixes #4448

dsyme added 2 commits

March 9, 2018 15:20


          fix cancellation for PostAndAsyncReply

744c01b


          fix tests

8735bed

dsyme mentioned this pull request

MailboxProcessor.PostAndAsyncReply doesn't handle CancellationToken properly #4448

Closed

Contributor Author

dsyme commented Mar 9, 2018

The fix is this line here: https://github.com/Microsoft/visualfsharp/pull/4477/files#diff-34ee82347e9e0b47265fcecaa4850174L2131

The rest is documentation/cleanup/testing

KevinRansom approved these changes

View reviewed changes

KevinRansom merged commit d49f3dd into dotnet:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet